Page MenuHomePhabricator
Differential D15886

Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck
ClosedPublic
Actions

Authored by epriestley on May 11 2016, 2:07 AM.
Tags
None
Referenced Files
F14064308: D15886.diff
Mon, Nov 18, 10:51 PM
F14052140: D15886.diff
Fri, Nov 15, 6:42 AM
F14037746: D15886.diff
Sun, Nov 10, 6:44 PM
F14030396: D15886.id38266.diff
Sat, Nov 9, 3:13 AM
F14030060: D15886.id.diff
Fri, Nov 8, 11:40 PM
F14030050: D15886.id38254.diff
Fri, Nov 8, 11:34 PM
F14029937: D15886.id.diff
Fri, Nov 8, 10:35 PM
F14029891: D15886.diff
Fri, Nov 8, 10:26 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10694: Improve behavior of context for inline comments in mail
Commits
rPcd86bf01746b: Remove `metamta.differential.unified-comment-context` and explain it in…
Summary

Ref T10694. This setting no longer has any effect: we always show a limited amount of context now.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
mail11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12129
Build 15298: Run Core Tests
Build 15297: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38254.May 11 2016, 2:07 AM
epriestley retitled this revision from to Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10694: Improve behavior of context for inline comments in mail.
chad accepted this revision.May 11 2016, 3:10 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 3:10 AM
Closed by commit rPcd86bf01746b: Remove `metamta.differential.unified-comment-context` and explain it in… (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:48 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 18 2016, 10:18 PM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
4 lines
differential/
config/
15 lines

Diff 38254

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
Phabricator · Built by Phacility