Paths

Table of Contentst

Differential D15886

Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck
ClosedPublic
Actions

Authored by epriestley on May 11 2016, 2:07 AM.

Details

Reviewers

chad

Maniphest Tasks

T10694: Improve behavior of context for inline comments in mail

Commits

rPcd86bf01746b: Remove `metamta.differential.unified-comment-context` and explain it in…

Summary

Ref T10694. This setting no longer has any effect: we always show a limited amount of context now.

Test Plan

grep

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38254.May 11 2016, 2:07 AM

epriestley retitled this revision from to Remove `metamta.differential.unified-comment-context` and explain it in ExtraConfigSetupCheck.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10694: Improve behavior of context for inline comments in mail.

chad accepted this revision.May 11 2016, 3:10 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 11 2016, 3:10 AM

Closed by commit rPcd86bf01746b: Remove `metamta.differential.unified-comment-context` and explain it in… (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:48 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 18 2016, 10:18 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

4 lines

differential/

config/

PhabricatorDifferentialConfigOptions.php

15 lines

Diff 38266

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php