Page MenuHomePhabricator
Differential D15879

Before executing svnserve, change the CWD to a readable directory
ClosedPublic
Actions

Authored by epriestley on May 10 2016, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:20 AM
Unknown Object (File)
Thu, Apr 25, 10:24 PM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Thu, Apr 18, 9:05 AM
Unknown Object (File)
Thu, Apr 11, 8:37 AM
Unknown Object (File)
Mar 20 2024, 6:09 PM
Unknown Object (File)
Mar 20 2024, 6:08 PM
Unknown Object (File)
Mar 20 2024, 5:13 PM
View All Files
Subscribers
dpotter

Details

Reviewers
chad
Maniphest Tasks
T10941: Subversion fails to execute pre-commit hook if CWD isn't readable
Commits
rPde4312bcdeab: Before executing svnserve, change the CWD to a readable directory
Summary

Fixes T10941. This avoids a confusing dead end when configuring Subversion hosting, where svnserve will fail to execute hooks if the CWD isn't readable by the vcs-user.

Test Plan
  • Updated and committed in a hosted SVN repository.
  • Ran some git operations, too.
  • @dpotter confirmed this locally in T10941.

Diff Detail

Repository
rP Phabricator
Branch
svnchdir1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12120
Build 15282: Run Core Tests
Build 15281: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38245.May 10 2016, 2:32 PM
epriestley retitled this revision from to Before executing svnserve, change the CWD to a readable directory.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10941: Subversion fails to execute pre-commit hook if CWD isn't readable.
epriestley added a subscriber: dpotter.
chad accepted this revision.May 11 2016, 3:05 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 3:05 AM
Closed by commit rPde4312bcdeab: Before executing svnserve, change the CWD to a readable directory (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
3 lines
ssh/
10 lines
infrastructure/
env/
17 lines

Diff 38245

View Options

src/applications/diffusion/protocol/DiffusionGitCommandEngine.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
Phabricator · Built by Phacility