Page MenuHomePhabricator
Differential D15862

Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine"
ClosedPublic
Actions

Authored by richardvanvelzen on May 6 2016, 3:11 PM.
Tags
None
Referenced Files
F15404976: D15862.id.diff
Tue, Mar 18, 9:53 AM
F15402841: D15862.diff
Tue, Mar 18, 12:36 AM
F15391346: D15862.id38208.diff
Sat, Mar 15, 9:26 AM
F15388345: D15862.id38207.diff
Sat, Mar 15, 3:41 AM
Unknown Object (File)
Wed, Feb 26, 10:05 PM
Unknown Object (File)
Feb 16 2025, 6:47 AM
Unknown Object (File)
Feb 9 2025, 1:31 AM
Unknown Object (File)
Jan 29 2025, 4:59 PM
View All Files
Subscribers
Korvin
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU609c137c338c: Revert "Reorder remarkup block rules for consistency with…
Summary

This reverts commit c0370f2f3c140d5048034ffdab617af7631d14ad.

The sorting behavior has changed between PHP 5 and 7. The msort at libphutil/src/markup/engine/PhutilRemarkupEngine.php:44 reorders slightly differently.

Test Plan

php5 ../arcanist/scripts/arcanist.php unit now doesn't show an error.

Diff Detail

Repository
rPHU libphutil
Branch
revert-remarkup-fix
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12082
Build 15222: arc lint + arc unit

Event Timeline

richardvanvelzen updated this revision to Diff 38207.May 6 2016, 3:11 PM
richardvanvelzen retitled this revision from to Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine".
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2016, 3:11 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley edited edge metadata.May 6 2016, 3:12 PM

Thanks. I filed T10929 to fix this properly.

epriestley awarded a token.May 6 2016, 3:12 PM
richardvanvelzen added a comment.May 6 2016, 3:14 PM

Awesome.

I'll create a dedicated PHP 5 vm to use for Phabricator development from now on. I'm not wanting to risk this kind of breakage.

richardvanvelzen added a comment.May 6 2016, 3:15 PM

(I'll be away from my machine for the weekend, when accepted it'd be best if you land this since I probably won't be able to)

epriestley accepted this revision.May 6 2016, 3:15 PM
epriestley edited edge metadata.

Whoops

This revision is now accepted and ready to land.May 6 2016, 3:15 PM
epriestley added a comment.May 6 2016, 3:16 PM

I'll land this in, like, 5 minutes if it seems like you immediately stood up from your desk and returned to your mountain fortress after mashing submit.

Closed by commit rPHU609c137c338c: Revert "Reorder remarkup block rules for consistency with… (authored by richardvanvelzen, committed by epriestley). · Explain WhyMay 6 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
markup/
engine/
__tests__/
6 lines100%
Loading...

Diff 38207

View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

Loading...
Phabricator · Built by Phacility