Page MenuHomePhabricator
Differential D15859

Reorder remarkup block rules for consistency with PhabricatorMarkupEngine
ClosedPublic
Actions

Authored by richardvanvelzen on May 6 2016, 8:54 AM.
Tags
None
Referenced Files
F15421244: D15859.id38204.diff
Fri, Mar 21, 9:58 PM
F15414579: D15859.id38201.diff
Thu, Mar 20, 1:17 AM
F15408388: D15859.id.diff
Tue, Mar 18, 10:42 PM
F15400123: D15859.diff
Mon, Mar 17, 9:50 AM
F15332978: D15859.id38201.diff
Fri, Mar 7, 10:51 PM
Unknown Object (File)
Feb 16 2025, 6:47 AM
Unknown Object (File)
Feb 13 2025, 6:36 AM
Unknown Object (File)
Feb 10 2025, 6:01 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine
Summary

I got consistent failures on the remarkup tests. This resolves that issue by bringing the order in line with the order used in PhabricatorMarkupEngine::newMarkupEngine

Test Plan

No more failures when running arc unit src/markup/engine/PhutilRemarkupEngine.php

Diff Detail

Repository
rPHU libphutil
Branch
remarkup-unit-order
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12076
Build 15215: arc lint + arc unit

Event Timeline

richardvanvelzen updated this revision to Diff 38201.May 6 2016, 8:54 AM
richardvanvelzen retitled this revision from to Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2016, 8:54 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.May 6 2016, 2:42 PM
epriestley edited edge metadata.

We should probably give blocks an explicit ordering at some point like rules have, I suppose.

This revision is now accepted and ready to land.May 6 2016, 2:42 PM
Closed by commit rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 6 2016, 2:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
6 lines

Diff 38201

View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

Loading...
Phabricator · Built by Phacility