Paths

Table of Contentst

Highlight inline diff context in HTML mail
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 5:49 PM.

Details

Reviewers

Maniphest Tasks

T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments
T10694: Improve behavior of context for inline comments in mail

Commits

rP94c7bb605c35: Highlight inline diff context in HTML mail

Summary

Ref T10694. Ref T9790. When generating inline diff context, highlight it and then mangle the highlighted output into style="..." so it works in HTML.

Also try to tighten up some spacing/formatting stuff.

Test Plan

Got some output in this vein:

Screen Shot 2016-05-05 at 10.45.09 AM.png (455×546 px, 63 KB)

Diff Detail

Repository

rP Phabricator

Branch

inline2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12066
Build 15200: Run Core Tests
Build 15199: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38190.May 5 2016, 5:49 PM

epriestley retitled this revision from to Highlight inline diff context in HTML mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10694: Improve behavior of context for inline comments in mail, T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

avivey awarded a token.May 5 2016, 6:08 PM

chad accepted this revision.May 5 2016, 6:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 5 2016, 6:12 PM

Closed by commit rP94c7bb605c35: Highlight inline diff context in HTML mail (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 6:13 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

editor/

DifferentialTransactionEditor.php

20 lines

mail/

DifferentialInlineCommentMailView.php

82 lines

parser/

DifferentialChangesetParser.php

42 lines

render/

DifferentialChangesetOneUpMailRenderer.php

98 lines

metamta/

view/

PhabricatorMetaMTAMailBody.php

7 lines

Diff 38190

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/differential/mail/DifferentialInlineCommentMailView.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Highlight inline diff context in HTML mailClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38190

src/__phutil_library_map__.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/differential/mail/DifferentialInlineCommentMailView.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Highlight inline diff context in HTML mail
ClosedPublic
Actions

Revision Contents
Changeset List