Paths

Table of Contentst

Differential D15847

When rendering Remarkup codeblocks, allow calling engines to provide a style map
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 1:39 AM.

Details

Reviewers

chad

Maniphest Tasks

T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments

Commits

rPHUe499b37f5dd3: When rendering Remarkup codeblocks, allow calling engines to provide a style map

Summary

Ref T9790.

Make the HTML version of code blocks look more like the web version.
If the caller passes a style map, reformat the body to use style="..." instead of class="..." for HTML mail mode.

Test Plan

Faked a style map and got some inline styles (red stuff) -- see also the "style" in the inspector:

Screen Shot 2016-05-04 at 6.37.26 PM.png (970×754 px, 228 KB)

Diff Detail

Repository

rPHU libphutil

Branch

syntax3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12053
Build 15180: Run Core Tests
Build 15179: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38175.May 5 2016, 1:39 AM

epriestley retitled this revision from to When rendering Remarkup codeblocks, allow calling engines to provide a style map.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.

chad accepted this revision.May 5 2016, 1:47 AM

chad edited edge metadata.

chad added inline comments.

src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php
147	(y)

This revision is now accepted and ready to land.May 5 2016, 1:47 AM

Synchronize more styles better: counterexample, headers, margins, font sizing.

Closed by commit rPHUe499b37f5dd3: When rendering Remarkup codeblocks, allow calling engines to provide a style map (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 9:51 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM

epriestley mentioned this in T9593: Counterexample header is incorrectly colored in email.May 6 2016, 12:41 AM

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

blockrule/

PhutilRemarkupCodeBlockRule.php

64 lines

Diff 38177

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php

When rendering Remarkup codeblocks, allow calling engines to provide a style mapClosedPublicActions