Page MenuHomePhabricator

Guarantee repositories have unique local paths
ClosedPublic

Authored by epriestley on May 3 2016, 7:40 PM.
Tags
None
Referenced Files
F15409600: D15837.id38149.diff
Wed, Mar 19, 4:45 AM
F15397608: D15837.diff
Sun, Mar 16, 9:18 PM
F15397348: D15837.diff
Sun, Mar 16, 7:41 PM
F15396592: D15837.diff
Sun, Mar 16, 3:17 PM
F15396395: D15837.diff
Sun, Mar 16, 1:56 PM
F15385445: D15837.id38149.diff
Fri, Mar 14, 10:37 PM
F15379768: D15837.id38149.diff
Thu, Mar 13, 11:16 PM
F15331625: D15837.id38149.diff
Fri, Mar 7, 12:00 PM
Subscribers
None

Details

Summary

Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with bin/repository move-paths by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't equivalent since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan
  • Ran migrations.
  • Grepped for local-path.
  • Listed and moved paths with bin/repository.
  • Created a new repository, verified its local path populated correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable