Page MenuHomePhabricator

Guarantee repositories have unique local paths
ClosedPublic

Authored by epriestley on May 3 2016, 7:40 PM.
Tags
None
Referenced Files
F17847483: D15837.id38165.diff
Sun, Jul 27, 6:10 AM
F17841805: D15837.id38149.diff
Sat, Jul 26, 10:52 PM
F17830399: D15837.id38149.diff
Sat, Jul 26, 11:02 AM
F17815435: D15837.diff
Fri, Jul 25, 9:58 PM
F17788773: D15837.id38149.diff
Thu, Jul 24, 6:13 PM
F17770191: D15837.id.diff
Wed, Jul 23, 9:21 AM
F17748239: D15837.diff
Mon, Jul 21, 11:35 PM
F17657577: D15837.diff
Sat, Jul 12, 12:24 PM
Subscribers
None

Details

Summary

Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with bin/repository move-paths by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't equivalent since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan
  • Ran migrations.
  • Grepped for local-path.
  • Listed and moved paths with bin/repository.
  • Created a new repository, verified its local path populated correctly.

Diff Detail

Repository
rP Phabricator
Branch
repo24
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12025
Build 15133: Run Core Tests
Build 15132: arc lint + arc unit