Page MenuHomePhabricator
Differential D15836

Add icons to the new repository edit nav
ClosedPublic
Actions

Authored by epriestley on May 3 2016, 1:56 PM.
Tags
None
Referenced Files
F13214808: D15836.id38148.diff
Fri, May 17, 1:04 PM
F13210996: D15836.diff
Fri, May 17, 5:23 AM
F13196321: D15836.diff
Sun, May 12, 11:10 PM
Unknown Object (File)
Fri, May 3, 3:49 AM
Unknown Object (File)
Mon, Apr 29, 3:54 PM
Unknown Object (File)
Thu, Apr 25, 9:58 AM
Unknown Object (File)
Wed, Apr 24, 11:49 PM
Unknown Object (File)
Apr 11 2024, 8:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rPc3afddec9c00: Add icons to the new repository edit nav
Summary

Ref T10748. These:

  • Look nice.
  • Hint at panel contents / effects.
  • Hint which panels have been customized.
  • Allow panels with issues or errors to be highlighted with an alert/attention icon.
Test Plan

Screen Shot 2016-05-03 at 6.54.37 AM.png (981×1 px, 165 KB)

Diff Detail

Repository
rP Phabricator
Branch
repo23
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php:19XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12021
Build 15128: Run Core Tests
Build 15127: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38145.May 3 2016, 1:56 PM
epriestley retitled this revision from to Add icons to the new repository edit nav.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Herald edited edge metadata. · View Herald TranscriptMay 3 2016, 1:56 PM
chad accepted this revision.May 3 2016, 2:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 3 2016, 2:17 PM
Closed by commit rPc3afddec9c00: Add icons to the new repository edit nav (authored by epriestley, committed by epriestley). · Explain WhyMay 3 2016, 3:01 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.May 5 2016, 12:15 AM

Revision Contents
Changeset List

Diff 38145

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryManageController.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryActionsManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryHistoryManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryPoliciesManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

Loading...
View Options

src/applications/drydock/query/DrydockAuthorizationQuery.php

Loading...
View Options

src/applications/drydock/storage/DrydockAuthorization.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-side-menu-view.css

Loading...
Phabricator · Built by Phacility