Differential D15836

Add icons to the new repository edit nav
ClosedPublic
Actions

Authored by epriestley on May 3 2016, 1:56 PM.

Details

Reviewers

chad

Maniphest Tasks

T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API

Commits

rPc3afddec9c00: Add icons to the new repository edit nav

Summary

Ref T10748. These:

Look nice.
Hint at panel contents / effects.
Hint which panels have been customized.
Allow panels with issues or errors to be highlighted with an alert/attention icon.

Test Plan

Screen Shot 2016-05-03 at 6.54.37 AM.png (981×1 px, 165 KB)

Diff Detail

Repository

rP Phabricator

Branch

repo23

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php:19	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 12021
Build 15128: Run Core Tests
Build 15127: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38145.May 3 2016, 1:56 PM

epriestley retitled this revision from to Add icons to the new repository edit nav.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

Herald edited edge metadata. · View Herald TranscriptMay 3 2016, 1:56 PM

chad accepted this revision.May 3 2016, 2:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 3 2016, 2:17 PM

Closed by commit rPc3afddec9c00: Add icons to the new repository edit nav (authored by epriestley, committed by epriestley). · Explain WhyMay 3 2016, 3:01 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.May 5 2016, 12:15 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

applications/

diffusion/

controller/

DiffusionRepositoryManageController.php

16 lines

management/

DiffusionRepositoryActionsManagementPanel.php

17 lines

DiffusionRepositoryAutomationManagementPanel.php

22 lines

DiffusionRepositoryBasicsManagementPanel.php

10 lines

DiffusionRepositoryBranchesManagementPanel.php

15 lines

DiffusionRepositoryHistoryManagementPanel.php

4 lines

DiffusionRepositoryManagementPanel.php

4 lines

DiffusionRepositoryPoliciesManagementPanel.php

32 lines

DiffusionRepositoryStagingManagementPanel.php

12 lines

DiffusionRepositoryStatusManagementPanel.php

27 lines

DiffusionRepositoryStorageManagementPanel.php

12 lines

DiffusionRepositorySymbolsManagementPanel.php

14 lines

DiffusionRepositoryURIsManagementPanel.php

6 lines

drydock/

query/

DrydockAuthorizationQuery.php

29 lines

storage/

DrydockAuthorization.php

5 lines

webroot/

rsrc/

css/

layout/

phabricator-side-menu-view.css

6 lines

Diff 38145

View Options

resources/celerity/map.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryManageController.php

View Options

src/applications/diffusion/management/DiffusionRepositoryActionsManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryHistoryManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryPoliciesManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

View Options

src/applications/drydock/query/DrydockAuthorizationQuery.php

View Options

src/applications/drydock/storage/DrydockAuthorization.php

View Options

webroot/rsrc/css/layout/phabricator-side-menu-view.css

Add icons to the new repository edit navClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38145

resources/celerity/map.php

src/applications/diffusion/controller/DiffusionRepositoryManageController.php

src/applications/diffusion/management/DiffusionRepositoryActionsManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryAutomationManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryHistoryManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryPoliciesManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryStagingManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

src/applications/drydock/query/DrydockAuthorizationQuery.php

src/applications/drydock/storage/DrydockAuthorization.php

webroot/rsrc/css/layout/phabricator-side-menu-view.css

Add icons to the new repository edit nav
ClosedPublic
Actions

Revision Contents
Changeset List