Page MenuHomePhabricator

Fix two issues with Remarkup in Pholio
ClosedPublic

Authored by epriestley on Apr 25 2016, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 12:09 PM
Unknown Object (File)
Oct 24 2024, 10:30 PM
Unknown Object (File)
Oct 18 2024, 9:46 PM
Unknown Object (File)
Oct 16 2024, 3:40 PM
Unknown Object (File)
Oct 13 2024, 11:55 PM
Unknown Object (File)
Sep 12 2024, 8:28 AM
Unknown Object (File)
Sep 5 2024, 7:52 PM
Unknown Object (File)
Sep 4 2024, 1:40 PM
Subscribers
None

Details

Summary

Fixes T10865.

  • Mock descriptions did not markup.
  • Image descriptions did not get a proper container <div />.
Test Plan
  • Created a mock with remarkup in the mock description and in an image description.
  • Viewed mock detail.
  • Saw list styles render properly in both mock description and image description.

Diff Detail

Repository
rP Phabricator
Branch
premark1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11915
Build 14973: Run Core Tests
Build 14972: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix two issues with Remarkup in Pholio.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 25 2016, 1:48 PM
This revision was automatically updated to reflect the committed changes.