Paths

Table of Contentst

Differential D15788

Fix bad variable causing `aphlict` to fail to start with no "logs" config
ClosedPublic
Actions

Authored by epriestley on Apr 24 2016, 1:35 PM.

Details

Reviewers

chad

Maniphest Tasks

T10863: Aphlict fails to start when "logs" option is omitted

Commits

rPaa9395e38fc9: Fix bad variable causing `aphlict` to fail to start with no "logs" config

Summary

Fixes T10863. See that task for discussion.

Test Plan

Configured aphlict with no "logs".
Started aphlict.
- Before change: exception.
- After change: worked.

Diff Detail

Repository

rP Phabricator

Branch

aphlict1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11909
Build 14962: Run Core Tests
Build 14961: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38035.Apr 24 2016, 1:35 PM

epriestley retitled this revision from to Fix bad variable causing `aphlict` to fail to start with no "logs" config.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10863: Aphlict fails to start when "logs" option is omitted.

chad accepted this revision.Apr 24 2016, 3:01 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 24 2016, 3:01 PM

Closed by commit rPaa9395e38fc9: Fix bad variable causing `aphlict` to fail to start with no "logs" config (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 26 2016, 3:18 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementWorkflow.php

2 lines

Diff 38035

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Fix bad variable causing `aphlict` to fail to start with no "logs" configClosedPublicActions