Make setCWD() with bad paths safer
ClosedPublic
Actions

Authored by epriestley on Apr 22 2016, 12:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture

Commits

rPHU1ea8d2ad6daa: (stable) Promote 2016 Week 17
rPHUb8058f6e29ba: Make setCWD() with bad paths safer

Summary

Ref T10853. This isn't a complete fix, but should prevent the most serious mistakes with setCWD() on bad paths.

Test Plan

Wrote a script using setCWD().
Gave it a bad path: got an explicit error.
Gave it a good path: things worked great.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38026.Apr 22 2016, 12:26 PM

epriestley retitled this revision from to Make setCWD() with bad paths safer.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10853: Make `setCWD('/does/not/exist')` safer on ExecFuture.

chad accepted this revision.Apr 22 2016, 2:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2016, 2:31 PM

Closed by commit rPHUb8058f6e29ba: Make setCWD() with bad paths safer (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2016, 3:10 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D20205: Refine checks against "cwd" before "proc_open()".Feb 22 2019, 11:40 PM

epriestley mentioned this in rPHU0679917944e1: Refine checks against "cwd" before "proc_open()".Feb 25 2019, 8:14 PM

Revision Contents
Changeset List

Path

Size

src/

future/

exec/

PhutilExecutableFuture.php

13 lines

Diff 38029

View Options

src/future/exec/PhutilExecutableFuture.php

Make setCWD() with bad paths saferClosedPublicActions