Page MenuHomePhabricator
Differential D15770

Better wording for cancelling/reinstating recurring events
ClosedPublic
Actions

Authored by lpriestley on Apr 20 2016, 4:54 PM.
Tags
None
Referenced Files
F13192184: D15770.id.diff
Sun, May 12, 6:09 AM
F13191791: D15770.id37997.diff
Sun, May 12, 12:33 AM
F13184321: D15770.id37996.diff
Fri, May 10, 5:40 PM
F13179464: D15770.diff
Wed, May 8, 9:13 PM
Unknown Object (File)
Sat, May 4, 6:46 PM
Unknown Object (File)
Wed, May 1, 12:08 AM
Unknown Object (File)
Mon, Apr 29, 9:13 AM
Unknown Object (File)
Sun, Apr 28, 8:32 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar
Commits
rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events
Summary

Fixes T10744

Test Plan

Create recurring event, cancel one instance, cancel the parent event, reinstate event. Wording in the reinstating dialog should be clear about reinstating only instances that haven't been individually cancelled.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37996.Apr 20 2016, 4:54 PM
lpriestley retitled this revision from to Better wording for cancelling/reinstating recurring events.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2016, 4:54 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 20 2016, 5:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 5:07 PM
Closed by commit rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events (authored by lpriestley, committed by lpriestley). · Explain WhyApr 20 2016, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
3 lines
4 lines

Diff 37997

View Options

src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
Phabricator · Built by Phacility