Better wording for cancelling/reinstating recurring events
ClosedPublic
Actions

Authored by lpriestley on Apr 20 2016, 4:54 PM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar

Commits

rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events

Summary

Fixes T10744

Test Plan

Create recurring event, cancel one instance, cancel the parent event, reinstate event. Wording in the reinstating dialog should be clear about reinstating only instances that haven't been individually cancelled.

Diff Detail

Repository

rP Phabricator

Branch

calendarcancelrecurrence

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11867
Build 14900: Run Core Tests
Build 14899: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37996.Apr 20 2016, 4:54 PM

lpriestley retitled this revision from to Better wording for cancelling/reinstating recurring events.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added reviewers: epriestley, chad.

lpriestley added a task: T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2016, 4:54 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 20 2016, 5:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2016, 5:07 PM

Closed by commit rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events (authored by lpriestley, committed by lpriestley). · Explain WhyApr 20 2016, 5:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventCancelController.php

3 lines

PhabricatorCalendarEventViewController.php

4 lines

Diff 37996

View Options

src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php