Page MenuHomePhabricator
Differential D15748

Record more details about where a write is taking place while holding a cluster lock
ClosedPublic
Actions

Authored by epriestley on Apr 18 2016, 3:30 PM.
Tags
None
Referenced Files
F22711199: D15748.id37950.diff
Sat, Oct 3, 1:19 PM
F22684543: D15748.diff
Fri, Oct 2, 4:29 AM
Unknown Object (File)
Sep 17 2026, 7:00 AM
Unknown Object (File)
Sep 12 2026, 10:38 PM
Unknown Object (File)
Aug 20 2026, 9:36 PM
Unknown Object (File)
Aug 19 2026, 7:05 PM
Unknown Object (File)
Jul 3 2026, 7:35 AM
Unknown Object (File)
Apr 2 2026, 6:24 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4292: Implement repository replication
Commits
rPf424f9f2d206: Record more details about where a write is taking place while holding a…
Summary

Ref T4292. This will let the UI and future bin/repository tools give administrators more tools to understand problems when reporting or resolving them.

Test Plan
  • Pushed fully clean repository.
  • Pushed previously-pushed repository.
  • Forced write to abort, inspected useful information in the database.

Diff Detail

Repository
rP Phabricator
Branch
rlock2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11821
Build 14830: Run Core Tests
Build 14829: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37948.Apr 18 2016, 3:30 PM
epriestley retitled this revision from to Record more details about where a write is taking place while holding a cluster lock.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4292: Implement repository replication.
chad accepted this revision.Apr 18 2016, 4:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 4:28 PM
Closed by commit rPf424f9f2d206: Record more details about where a write is taking place while holding a… (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2016, 6:55 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 19 2016, 9:29 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
diffusion/
ssh/
3 lines
repository/
storage/
10 lines
23 lines

Diff 37948

View Options

resources/sql/autopatches/20160418.repoversion.1.sql

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryWorkingCopyVersion.php

Loading...
Phabricator · Built by Phacility