Paths

Table of Contentst

Differential D15744

Add missing RepositoryURI table + run storage adjustments in tests
ClosedPublic
Actions

Authored by epriestley on Apr 18 2016, 11:46 AM.

Tags

None

Referenced Files

	F15257526: D15744.diff
	Tue, Feb 25, 4:14 AM

	Unknown Object (File)
	Sun, Feb 16, 6:42 AM

	Unknown Object (File)
	Tue, Feb 11, 5:50 AM

	Unknown Object (File)
	Mon, Feb 10, 6:17 PM

	Unknown Object (File)
	Sun, Feb 9, 2:44 PM

	Unknown Object (File)
	Sun, Feb 9, 1:20 AM

	Unknown Object (File)
	Mon, Feb 3, 5:32 PM

	Unknown Object (File)
	Mon, Jan 27, 6:12 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10366: General support for multiple URIs for a repository
T10830: phabricator_repository.repository_uri Missing

Commits

rP9352ed8abbd2: Add missing RepositoryURI table + run storage adjustments in tests

Summary

Fixes T10830. Ref T10366. I wasn't writing to this table yet so I didn't build it, but the fact that bin/storage adjust would complain slipped my mind.

Add the table.
Make the tests run adjust. This is a little slow (a few extra seconds) but we could eventually move some steps like this to run server-side only.

Test Plan

Ran bin/storage upgrade -f, got a clean adjust.

Diff Detail

Repository

Branch

repotable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11813
Build 14818: Run Core Tests
Build 14817: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37941.Apr 18 2016, 11:46 AM

epriestley retitled this revision from to Add missing RepositoryURI table + run storage adjustments in tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10830: phabricator_repository.repository_uri Missing, T10366: General support for multiple URIs for a repository.

epriestley mentioned this in T10830: phabricator_repository.repository_uri Missing.Apr 18 2016, 11:54 AM

chad accepted this revision.Apr 18 2016, 1:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 18 2016, 1:43 PM

Closed by commit rP9352ed8abbd2: Add missing RepositoryURI table + run storage adjustments in tests (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2016, 2:54 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 19 2016, 9:06 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160418.repouri.1.sql

14 lines

src/

applications/

repository/

storage/

PhabricatorRepositoryURI.php

2 lines

infrastructure/

testing/

fixture/

PhabricatorStorageFixtureScopeGuard.php

2 lines

Diff 37941

resources/sql/autopatches/20160418.repouri.1.sql

Loading...

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...

src/infrastructure/testing/fixture/PhabricatorStorageFixtureScopeGuard.php

Loading...