Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured
ClosedPublic
Actions

Authored by epriestley on Apr 15 2016, 8:53 PM.

Details

Reviewers

chad
areitz

Maniphest Tasks

T6806: Raise severity of "phd.user" warning eventually

Commits

rPf146f4577ea7: Fail explicitly instead of continuing with a warning if "phd.user" is…

Summary

Fixes T6806. We haven't seen users having issues with phd.user in a very long time.

Test Plan

Configured daemons to run as notepriestley, got a well-explained exception.
Configured daemons to run as epriestley, got a clean start.
Configured daemons with phd.user=null, got a clean start.

Diff Detail

Repository

rP Phabricator

Branch

daemon5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11766
Build 14745: Run Core Tests
Build 14744: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37897.Apr 15 2016, 8:53 PM

epriestley retitled this revision from to Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T6806: Raise severity of "phd.user" warning eventually.

LGTM, I think this is the right thing to do.

This revision is now accepted and ready to land.Apr 15 2016, 9:06 PM

Print slightly more information in the exception message.

Usage Exception: Daemons are configured to run as user "notepriestley" in configuration option `phd.user`, but the current user is "epriestley" and `phd` was unable to switch to the correct user with `sudo`. Command output:

Command failed with error #1!
COMMAND
exec sudo -En -u 'notepriestley' -- ./phd-daemon '-l' 'local'

STDOUT
(empty)

STDERR
sudo: unknown user: notepriestley

Closed by commit rPf146f4577ea7: Fail explicitly instead of continuing with a warning if "phd.user" is… (authored by epriestley, committed by epriestley). · Explain WhyApr 15 2016, 9:09 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12061: When problems occur in phd inside sudo error messages are neither printed nor logged.Jan 5 2017, 3:09 AM