Page MenuHomePhabricator

Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured
ClosedPublic

Authored by epriestley on Apr 15 2016, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 10:53 AM
Unknown Object (File)
Sat, Dec 21, 2:11 AM
Unknown Object (File)
Fri, Dec 20, 11:56 AM
Unknown Object (File)
Tue, Dec 17, 1:27 AM
Unknown Object (File)
Thu, Dec 5, 8:41 PM
Unknown Object (File)
Wed, Nov 27, 12:25 PM
Unknown Object (File)
Nov 23 2024, 3:42 AM
Unknown Object (File)
Nov 23 2024, 3:42 AM
Subscribers

Details

Summary

Fixes T6806. We haven't seen users having issues with phd.user in a very long time.

Test Plan
  • Configured daemons to run as notepriestley, got a well-explained exception.
  • Configured daemons to run as epriestley, got a clean start.
  • Configured daemons with phd.user=null, got a clean start.

Diff Detail

Repository
rP Phabricator
Branch
daemon5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11769
Build 14751: Run Core Tests
Build 14750: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
areitz added a reviewer: areitz.
areitz added a subscriber: areitz.

LGTM, I think this is the right thing to do.

This revision is now accepted and ready to land.Apr 15 2016, 9:06 PM
epriestley edited edge metadata.
  • Print slightly more information in the exception message.
Usage Exception: Daemons are configured to run as user "notepriestley" in configuration option `phd.user`, but the current user is "epriestley" and `phd` was unable to switch to the correct user with `sudo`. Command output:

Command failed with error #1!
COMMAND
exec sudo -En -u 'notepriestley' -- ./phd-daemon '-l' 'local'

STDOUT
(empty)

STDERR
sudo: unknown user: notepriestley
This revision was automatically updated to reflect the committed changes.