Differential D15702

Move Aphlict logging and PID configuration options to config file
ClosedPublic
Actions

Authored by epriestley on Apr 13 2016, 6:46 PM.

Tags

None

Referenced Files

	F15501843: D15702.diff
	Sun, Apr 13, 10:06 PM

	F15498680: D15702.id37845.diff
	Sun, Apr 13, 1:51 PM

	F15497925: D15702.id37829.diff
	Sun, Apr 13, 11:32 AM

	F15489428: D15702.id.diff
	Fri, Apr 11, 9:00 AM

	F15485870: D15702.diff
	Thu, Apr 10, 3:12 AM

	F15469872: D15702.diff
	Fri, Apr 4, 5:35 PM

	F15417533: D15702.id37845.diff
	Thu, Mar 20, 5:27 PM

	F15417532: D15702.id37829.diff
	Thu, Mar 20, 5:27 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10697: Move Aphlict server configuration to a separate configuration file

Commits

rPc6b092595497: Move Aphlict logging and PID configuration options to config file

Summary

Ref T10697. Mostly straightforward. Also allow the server to have multiple logs and log options in the future (e.g., different verbosities or separate admin/client logs or whatever). No specific plans for this, but the default log is pretty noisy today.

Test Plan

Set up a couple of logs, started server, saw it log to them.

Diff Detail

Repository

Branch

aphlict4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11697
Build 14649: Run Core Tests
Build 14648: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37829.Apr 13 2016, 6:46 PM

epriestley retitled this revision from to Move Aphlict logging and PID configuration options to config file.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10697: Move Aphlict server configuration to a separate configuration file.

🙈🙈🙈

This revision is now accepted and ready to land.Apr 13 2016, 6:51 PM

Closed by commit rPc6b092595497: Move Aphlict logging and PID configuration options to config file (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 11:55 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 14 2016, 5:50 PM

Revision Contents
Changeset List

Path

Size

conf/

aphlict/

aphlict.default.json

8 lines

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementWorkflow.php

62 lines

config/

check/

PhabricatorExtraConfigSetupCheck.php

2 lines

option/

PhabricatorNotificationConfigOptions.php

7 lines

docs/

user/

configuration/

notifications.diviner

11 lines

support/

aphlict/

server/

aphlict_server.js

20 lines

Diff 37829

conf/aphlict/aphlict.default.json

Loading...

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorNotificationConfigOptions.php

Loading...

src/docs/user/configuration/notifications.diviner

Loading...

support/aphlict/server/aphlict_server.js

Loading...