Page MenuHomePhabricator
Differential D15698

Minor `bin/aphlict` cleanup
ClosedPublic
Actions

Authored by epriestley on Apr 13 2016, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 1:15 AM
Unknown Object (File)
Sat, Jan 25, 10:22 PM
Unknown Object (File)
Sat, Jan 25, 3:07 AM
Unknown Object (File)
Fri, Jan 24, 1:05 PM
Unknown Object (File)
Fri, Jan 24, 1:05 PM
Unknown Object (File)
Fri, Jan 24, 1:05 PM
Unknown Object (File)
Wed, Jan 22, 2:20 AM
Unknown Object (File)
Fri, Jan 17, 5:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10697: Move Aphlict server configuration to a separate configuration file
Commits
rPa2588d62e7f6: Minor `bin/aphlict` cleanup
Summary

Ref T10697. This just improves a couple of minor bin/aphlict things: make argument parsing more explicit/consistent, consolidate a little bit of duplicated code.

Test Plan

Ran all bin/aphlict commands.

Diff Detail

Repository
rP Phabricator
Branch
aphlict1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11690
Build 14636: Run Core Tests
Build 14635: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37822.Apr 13 2016, 3:52 PM
epriestley retitled this revision from to Minor `bin/aphlict` cleanup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10697: Move Aphlict server configuration to a separate configuration file.
chad accepted this revision.Apr 13 2016, 5:34 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2016, 5:34 PM
Closed by commit rPa2588d62e7f6: Minor `bin/aphlict` cleanup (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 11:54 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 14 2016, 5:50 PM

Revision Contents
Changeset List

Diff 37822

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementDebugWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStartWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStopWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
Phabricator · Built by Phacility