Ignore post-write repository synchronization if no devices are configured
ClosedPublic
Actions

Authored by epriestley on Apr 13 2016, 1:23 AM.

Tags

None

Referenced Files

	F13229973: D15692.id37810.diff
	Mon, May 20, 7:59 PM

	F13228776: D15692.id37810.diff
	Mon, May 20, 11:57 AM

	F13225934: D15692.id37811.diff
	Sun, May 19, 6:23 PM

	F13205187: D15692.diff
	Wed, May 15, 1:34 AM

	F13188538: D15692.diff
	Sat, May 11, 5:19 AM

	Unknown Object (File)
	Tue, May 7, 8:33 AM

	Unknown Object (File)
	Mon, May 6, 2:17 PM

	Unknown Object (File)
	Mon, May 6, 6:35 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10789: Can't push to git remote repository

Commits

rP33060d16520b: Ignore post-write repository synchronization if no devices are configured

Summary

Fixes T10789. If we aren't configured with a device, we never grabbed a lock in the first place, and should not expect one to be held.

Test Plan

Pushed non-cluster-configured Git SSH repository.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37810.Apr 13 2016, 1:23 AM

epriestley retitled this revision from to Ignore post-write repository synchronization if no devices are configured.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10789: Can't push to git remote repository.

chad accepted this revision.Apr 13 2016, 1:25 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2016, 1:25 AM

Closed by commit rP33060d16520b: Ignore post-write repository synchronization if no devices are configured (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2016, 1:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

13 lines

Diff 37811

View Options

src/applications/repository/storage/PhabricatorRepository.php

Ignore post-write repository synchronization if no devices are configuredClosedPublicActions