First stab at a badges typeahead
ClosedPublic
Actions

Authored by lpriestley on Apr 9 2016, 6:41 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10702: "Award Badge" action on user profiles should use a typeahead for badge selection

Commits

rP85d2fda08259: First stab at a badges typeahead

Summary

Ref T10702

Test Plan

Open a user profile, attempt to award an archived or previously awarded badge, badges dialog should provide a typeahead, and the suggestions should offer details about whether a badge is archived or already awarded.

Diff Detail

Repository

rP Phabricator

Branch

badgesdatasource

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11658
Build 14587: Run Core Tests
Build 14586: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37751.Apr 9 2016, 6:41 PM

lpriestley retitled this revision from to First stab at a badges typeahead.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T10702: "Award Badge" action on user profiles should use a typeahead for badge selection.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 9 2016, 6:41 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Removing commented out code

epriestley accepted this revision.Apr 9 2016, 7:42 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/badges/controller/PhabricatorBadgesAwardController.php
20–21	For consistency, maybe rename this to `badgePHIDs` since it's a list now.
src/applications/badges/typeahead/PhabricatorBadgesDatasource.php
28	This will load some extra data we don't need. Use a separate `awardquery` to just fetch awards to the recipient instead.