Page MenuHomePhabricator
Differential D15672

When no master database is configured, automatically degrade to read-only mode
ClosedPublic
Actions

Authored by epriestley on Apr 10 2016, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 7:44 PM
Unknown Object (File)
Sat, Apr 20, 7:44 PM
Unknown Object (File)
Sat, Apr 20, 7:44 PM
Unknown Object (File)
Fri, Apr 19, 4:25 PM
Unknown Object (File)
Tue, Apr 16, 11:54 AM
Unknown Object (File)
Sun, Apr 7, 10:41 AM
Unknown Object (File)
Wed, Apr 3, 12:24 AM
Unknown Object (File)
Tue, Mar 26, 10:20 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4571: Allow Phabricator to run in Read-Only Mode
Commits
rPe0a8cac703d1: When no master database is configured, automatically degrade to read-only mode
Summary

Ref T4571. If cluster.databases is configured but only has replicas, implicitly drop to read-only mode and send writes to a replica.

Test Plan
  • Disabled the master, saw Phabricator automatically degrade into read-only mode against replicas.
  • (Also tested: explicit read-only mode, non-cluster mode, properly configured cluster mode).

Diff Detail

Repository
rP Phabricator
Branch
readonly9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/cluster/PhabricatorDatabaseRef.php:357XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11633
Build 14553: Run Core Tests
Build 14552: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37764.Apr 10 2016, 12:24 PM
epriestley retitled this revision from to When no master database is configured, automatically degrade to read-only mode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4571: Allow Phabricator to run in Read-Only Mode.
chad accepted this revision.Apr 10 2016, 3:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2016, 3:50 PM
Closed by commit rPe0a8cac703d1: When no master database is configured, automatically degrade to read-only mode (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2016, 7:19 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 11 2016, 3:43 PM

Revision Contents
Changeset List

Diff 37764

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/system/controller/PhabricatorSystemReadOnlyController.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorClusterException.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorClusterExceptionHandler.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorClusterImproperWriteException.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...
Phabricator · Built by Phacility