Differential D15670

Use new first-class MySQL timeout support in Phabricator
ClosedPublic
Actions

Authored by epriestley on Apr 10 2016, 11:03 AM.

Details

Reviewers

chad

Maniphest Tasks

T6710: Support "timeout" in vanilla MySQL connections

Commits

rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator

Summary

Fixes T6710. After D15669, we support a proper timeout parameter, so we don't need this hack anymore.

Test Plan

See D15669: forced a MySQL connector, set a low timeout, set a bad database, saw fast failures.

Diff Detail

Repository

rP Phabricator

Branch

readonly7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11630
Build 14547: Run Core Tests
Build 14546: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37761.Apr 10 2016, 11:03 AM

epriestley retitled this revision from to Use new first-class MySQL timeout support in Phabricator.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T6710: Support "timeout" in vanilla MySQL connections.

chad accepted this revision.Apr 10 2016, 3:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 10 2016, 3:44 PM

Closed by commit rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2016, 7:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 11 2016, 3:43 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

4 lines

Diff 37761

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Use new first-class MySQL timeout support in PhabricatorClosedPublicActions