Page MenuHomePhabricator

Lay `cluster.databases` configuration groundwork for database clustering
ClosedPublic

Authored by epriestley on Apr 9 2016, 1:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 11:44 PM
Unknown Object (File)
Sat, Mar 2, 11:44 PM
Unknown Object (File)
Sat, Mar 2, 11:38 PM
Unknown Object (File)
Feb 23 2024, 7:14 AM
Unknown Object (File)
Feb 20 2024, 2:33 AM
Unknown Object (File)
Feb 4 2024, 12:48 AM
Unknown Object (File)
Jan 27 2024, 1:32 AM
Unknown Object (File)
Jan 26 2024, 4:07 AM
Subscribers

Details

Summary

Ref T4571. This adds a new option which allows you to upgrade your one-host configuration to a multi-host configuration by configuring it.

Doing this currently does nothing. I wrote a lot of words about what it is supposed to do in the future, though.

Test Plan
  • Tried to configure the option in all the possible bad ways, got errors.
  • Read documentation.

Diff Detail

Repository
rP Phabricator
Branch
readonly3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/check/PhabricatorMySQLSetupCheck.php:23XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11615
Build 14523: Run Core Tests
Build 14522: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Lay `cluster.databases` configuration groundwork for database clustering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 9 2016, 3:40 PM

general question here: this seems to support a single datacenter only. That is, to have failover in a different datacenter would require different config between different DCs. If not, phabricator might try to make cross DC requests if the master is unreachable.

Would it be possible to support DC aware cluster configuration?

Can you give me a scenario or list of scenarios where a Phabricator webserver would make a different decision and achieve a better outcome if it was datacenter-aware?

In the cases I can come up with, the outcome is not meaningfully better by adding datacenter awareness: we still fail or succeed in roughly the same manner. But I may just not be thinking of the same situation you are.

This revision was automatically updated to reflect the committed changes.