Page MenuHomePhabricator
Differential D15656

Make badges searchable by name
ClosedPublic
Actions

Authored by lpriestley on Apr 7 2016, 7:13 PM.
Tags
None
Referenced Files
F15459121: D15656.id37731.diff
Mon, Mar 31, 10:00 AM
F15448380: D15656.id37729.diff
Fri, Mar 28, 4:32 AM
F15445769: D15656.id37732.diff
Thu, Mar 27, 3:56 PM
F15439225: D15656.id.diff
Wed, Mar 26, 6:25 AM
F15436748: D15656.diff
Tue, Mar 25, 4:23 PM
F15416311: D15656.id37729.diff
Thu, Mar 20, 10:29 AM
F15401171: D15656.diff
Mon, Mar 17, 4:07 PM
F15393473: D15656.id37729.diff
Sat, Mar 15, 9:01 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10690: Allow badges to be searched by name
Commits
rP1f423c3bd105: Make badges searchable by name
Summary

Closes T10690

Test Plan

Open Badges application, go to Advanced Search, search for a badge by its name and see result.

Diff Detail

Repository
rP Phabricator
Branch
badgesnamesearch
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11594
Build 14492: Run Core Tests
Build 14491: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37729.Apr 7 2016, 7:13 PM
lpriestley retitled this revision from to Make badges searchable by name.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T10690: Allow badges to be searched by name.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 7 2016, 7:13 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 7 2016, 7:19 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
17–18

I think you can just delete this method completely now -- it's no longer required for searchengines which implement buildCusotmSearchFields().

This revision is now accepted and ready to land.Apr 7 2016, 7:19 PM
lpriestley updated this revision to Diff 37731.Apr 7 2016, 7:25 PM
lpriestley edited edge metadata.

Removing obsolete method

Closed by commit rP1f423c3bd105: Make badges searchable by name (authored by lpriestley, committed by lpriestley). · Explain WhyApr 7 2016, 7:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8788: Allow querying for files by name.Apr 9 2017, 11:24 AM
amckinley mentioned this in D17702: Implement ngram search for File objects.Apr 17 2017, 7:14 PM
amckinley mentioned this in rP976fbee877c9: Implement ngram search for File objects.Apr 18 2017, 12:37 AM

Revision Contents
Changeset List

Diff 37731

View Options

resources/sql/autopatches/20160406.badges.ngrams.php

Loading...
View Options

resources/sql/autopatches/20160406.badges.ngrams.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesQuery.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadgeNameNgrams.php

Loading...
Phabricator · Built by Phacility