Page MenuHomePhabricator
Differential D15655

Convert Countdown to EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 7 2016, 6:49 PM.
Tags
None
Referenced Files
F15427400: D15655.id37733.diff
Sun, Mar 23, 2:13 PM
F15425896: D15655.id37733.diff
Sun, Mar 23, 6:35 AM
F15402802: D15655.id37727.diff
Tue, Mar 18, 12:25 AM
F15354057: D15655.id.diff
Tue, Mar 11, 1:44 AM
F15340911: D15655.id37733.diff
Sun, Mar 9, 5:37 PM
F15338222: D15655.id37733.diff
Sun, Mar 9, 9:58 AM
Unknown Object (File)
Feb 16 2025, 6:37 AM
Unknown Object (File)
Feb 12 2025, 8:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10520: Allow users to add other users as CC at countdown
T10684: Need a PhabricatorDateEditField
Commits
rPcdec31914390: Convert Countdown to EditEngine
Summary

Fixes T10684. Fixes T10520. This primarily implements a date/epoch field, and then does a bunch of standard plumbing.

Test Plan
  • Created countdowns.
  • Edited countdowns.
  • Used HTTP prefilling.
  • Created a countdown ending on "Christmas Morning", etc.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11590
Build 14485: Run Core Tests
Build 14484: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37727.Apr 7 2016, 6:49 PM
epriestley retitled this revision from to Convert Countdown to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10684: Need a PhabricatorDateEditField.
epriestley updated this object.Apr 7 2016, 6:49 PM
epriestley added a task: T10520: Allow users to add other users as CC at countdown.
chad accepted this revision.Apr 7 2016, 7:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2016, 7:31 PM
Closed by commit rPcdec31914390: Convert Countdown to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyApr 7 2016, 7:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37727

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/httpparametertype/AphrontEpochHTTPParameterType.php

Loading...
View Options

src/applications/countdown/application/PhabricatorCountdownApplication.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownCommentController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownListController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/countdown/editor/PhabricatorCountdownEditEngine.php

Loading...
View Options

src/applications/countdown/editor/PhabricatorCountdownEditor.php

Loading...
View Options

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...
View Options

src/applications/countdown/storage/PhabricatorCountdownTransaction.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEpochEditField.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Phabricator · Built by Phacility