Page MenuHomePhabricator

Don't dead-end users with out-of-date links to files
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 1:53 PM
Unknown Object (File)
Thu, Jan 2, 4:01 AM
Unknown Object (File)
Tue, Dec 24, 9:55 PM
Unknown Object (File)
Sat, Dec 21, 1:30 AM
Unknown Object (File)
Dec 11 2024, 4:30 PM
Unknown Object (File)
Dec 1 2024, 12:26 AM
Unknown Object (File)
Nov 30 2024, 6:17 PM
Unknown Object (File)
Nov 29 2024, 12:15 PM
Subscribers
None

Details

Summary

Ref T10262. Instead of dumping an unhelpful 403 "ACCESS DENIED" page on users, explain the most likely cause of the issue and give them a link to return to the file detail page to learn more or get an up-to-date link.

Test Plan

Hit both errors, had a lovely experience with the helpful dialog text.

Diff Detail

Repository
rP Phabricator
Branch
files4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11578
Build 14466: Run Core Tests
Build 14465: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't dead-end users with out-of-date links to files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.