Page MenuHomePhabricator

Don't dead-end users with out-of-date links to files
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:20 PM.
Tags
None
Referenced Files
F15480821: D15650.diff
Tue, Apr 8, 4:46 PM
F15480803: D15650.diff
Tue, Apr 8, 4:33 PM
F15480755: D15650.diff
Tue, Apr 8, 4:14 PM
F15480111: D15650.diff
Tue, Apr 8, 11:48 AM
F15480090: D15650.diff
Tue, Apr 8, 11:32 AM
F15471974: D15650.diff
Sat, Apr 5, 10:17 AM
F15463699: D15650.diff
Wed, Apr 2, 2:14 AM
F15388853: D15650.id.diff
Sat, Mar 15, 4:32 AM
Subscribers
None

Details

Summary

Ref T10262. Instead of dumping an unhelpful 403 "ACCESS DENIED" page on users, explain the most likely cause of the issue and give them a link to return to the file detail page to learn more or get an up-to-date link.

Test Plan

Hit both errors, had a lovely experience with the helpful dialog text.

Diff Detail

Repository
rP Phabricator
Branch
files4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11578
Build 14466: Run Core Tests
Build 14465: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't dead-end users with out-of-date links to files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.