Page MenuHomePhabricator

Don't dead-end users with out-of-date links to files
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:20 PM.
Tags
None
Referenced Files
F13178184: D15650.diff
Wed, May 8, 8:14 PM
Unknown Object (File)
Tue, May 7, 1:26 AM
Unknown Object (File)
Tue, Apr 30, 11:17 AM
Unknown Object (File)
Sat, Apr 27, 1:43 AM
Unknown Object (File)
Thu, Apr 25, 2:17 AM
Unknown Object (File)
Fri, Apr 19, 4:23 PM
Unknown Object (File)
Wed, Apr 17, 2:55 PM
Unknown Object (File)
Fri, Apr 12, 7:46 AM
Subscribers
None

Details

Summary

Ref T10262. Instead of dumping an unhelpful 403 "ACCESS DENIED" page on users, explain the most likely cause of the issue and give them a link to return to the file detail page to learn more or get an up-to-date link.

Test Plan

Hit both errors, had a lovely experience with the helpful dialog text.

Diff Detail

Repository
rP Phabricator
Branch
files4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11578
Build 14466: Run Core Tests
Build 14465: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't dead-end users with out-of-date links to files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.