Page MenuHomePhabricator
Differential D15636

Expose column positions via maniphest.edit
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 6:37 AM
Unknown Object (File)
Sun, Feb 16, 6:37 AM
Unknown Object (File)
Sun, Feb 16, 6:37 AM
Unknown Object (File)
Wed, Feb 12, 8:52 AM
Unknown Object (File)
Sun, Feb 9, 1:13 AM
Unknown Object (File)
Wed, Feb 5, 10:50 PM
Unknown Object (File)
Tue, Jan 28, 1:12 AM
Unknown Object (File)
Tue, Jan 28, 1:11 AM
View All Files
Subscribers
AmyLewis

Details

Reviewers
chad
Maniphest Tasks
T5214: Add Conduit API methods for workboards
T6027: Way to edit which column a task is in from the task itself
T10486: Error when creating a sub-task from a prefilled URL that includes `column`
Commits
rPecd4dd4e0b08: Expose column positions via maniphest.edit
Summary

Ref T5214. Fixes T10486. Ref T6027. This exposes the TYPE_COLUMNS transaction in a usable way via API, and fixes the interactions via prefilling.

Test Plan
  • Created tasks directly into columns via API.
  • Moved tasks between columns via API.
  • Used ?column=... to try to create a template task with valid and bogus column PHIDs.

Diff Detail

Repository
rP Phabricator
Branch
column3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conduit/parametertype/ConduitColumnsParameterType.php:6XHP63Useless Overriding Method
Unit
Tests Passed
Build Status
Buildable 11541
Build 14412: Run Core Tests
Build 14411: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37675.Apr 6 2016, 11:38 AM
epriestley retitled this revision from to Expose column positions via maniphest.edit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10486: Error when creating a sub-task from a prefilled URL that includes `column`, T6027: Way to edit which column a task is in from the task itself, T5214: Add Conduit API methods for workboards.
epriestley mentioned this in T10486: Error when creating a sub-task from a prefilled URL that includes `column`.Apr 6 2016, 11:45 AM
epriestley mentioned this in T6027: Way to edit which column a task is in from the task itself.Apr 6 2016, 12:23 PM
AmyLewis added a subscriber: AmyLewis.Apr 6 2016, 12:29 PM
chad accepted this revision.Apr 6 2016, 3:36 PM
chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/editor/ManiphestEditEngine.php
112

an

This revision is now accepted and ready to land.Apr 6 2016, 3:36 PM
epriestley added inline comments.Apr 6 2016, 3:38 PM
src/applications/maniphest/editor/ManiphestEditEngine.php
112

why thank you :3

epriestley updated this revision to Diff 37679.Apr 6 2016, 3:39 PM
epriestley edited edge metadata.
  • "a" -> "an"
  • Also say "may select a position" instead of "should select a position", since you can do whatever you want!
Closed by commit rPecd4dd4e0b08: Expose column positions via maniphest.edit (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
conduit/
parametertype/
38 lines
maniphest/
editor/
58 lines
transactions/
editfield/
21 lines
storage/
1 line

Diff 37675

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitColumnsParameterType.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorColumnsEditField.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility