Page MenuHomePhabricator

Expose column positions via maniphest.edit
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 5:24 PM
Unknown Object (File)
Wed, Mar 20, 4:46 PM
Unknown Object (File)
Tue, Mar 19, 7:35 PM
Unknown Object (File)
Wed, Mar 13, 7:16 PM
Unknown Object (File)
Wed, Mar 13, 7:15 PM
Unknown Object (File)
Fri, Mar 8, 9:21 PM
Unknown Object (File)
Fri, Mar 8, 7:16 PM
Unknown Object (File)
Fri, Mar 8, 7:16 PM
Subscribers

Details

Summary

Ref T5214. Fixes T10486. Ref T6027. This exposes the TYPE_COLUMNS transaction in a usable way via API, and fixes the interactions via prefilling.

Test Plan
  • Created tasks directly into columns via API.
  • Moved tasks between columns via API.
  • Used ?column=... to try to create a template task with valid and bogus column PHIDs.

Diff Detail

Repository
rP Phabricator
Branch
column3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conduit/parametertype/ConduitColumnsParameterType.php:6XHP63Useless Overriding Method
Unit
Tests Passed
Build Status
Buildable 11541
Build 14412: Run Core Tests
Build 14411: arc lint + arc unit

Event Timeline

chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/editor/ManiphestEditEngine.php
112

an

This revision is now accepted and ready to land.Apr 6 2016, 3:36 PM
src/applications/maniphest/editor/ManiphestEditEngine.php
112

why thank you :3

epriestley edited edge metadata.
  • "a" -> "an"
  • Also say "may select a position" instead of "should select a position", since you can do whatever you want!
This revision was automatically updated to reflect the committed changes.