Fix arc on windows not working with proc_open
Needs ReviewPublic
Actions

Authored by • paladox on Apr 3 2016, 7:19 PM.

Details

Reviewers: None

Summary

Switch functions fetchTarget and pushChange from execPassthru to execxLocal

Reason because it kept failing with this error

$ arc land
Landing current branch 'master'.
TARGET Landing onto "master", selected by following tracking branches upstream to the closest remote.
REMOTE Using remote "origin", selected by following tracking branches upstream to the closest remote.
FETCH Fetching origin/master...
Exception
Failed to passthru proc_open(): proc_open(): CreateProcess failed, error code - 87
(Run with --trace for a full exception trace.)

When running arc diff or arc land

With this fix applied to be able to do arc land you have to do arc diff first then arc land or else
you will get the revision does not exist.

Change-Id: Id5dea5237f92808b7864382da1ed28d06724e731

Test Plan

Do not use proc_open for now for arc land.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 11458
Build 14290: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,647 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #1! COMMAND "make" -C "C:\Users\patrick\libphutil\support\xhpast" "SKIP_PARSER=1" "SKIP_SCANNER=1" "clean" "all" "install"
	279 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") 1 assertion passed.
	94 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") 1 assertion passed.

Event Timeline

• paladox updated this revision to Diff 37590.Apr 3 2016, 7:19 PM

• paladox retitled this revision from to Fix arc on windows not working with proc_open.

• paladox updated this object.

• paladox edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 3 2016, 7:19 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Unit tests failed because they used the make command on windows that is not supported yet but soon Ubuntu will be available on windows so we will be able to use that command hopefully.

• paladox edited edge metadata.Apr 3 2016, 7:20 PM

• paladox added subscribers: 20after4, chad.