Page MenuHomePhabricator
Differential D15590

Adding awarder info to recipient list on badge view
ClosedPublic
Actions

Authored by lpriestley on Apr 3 2016, 2:19 AM.
Tags
None
Referenced Files
F15413961: D15590.diff
Wed, Mar 19, 10:12 PM
F15403139: D15590.id37580.diff
Tue, Mar 18, 1:59 AM
F15396076: D15590.id37585.diff
Sun, Mar 16, 11:41 AM
F15369931: D15590.id37580.diff
Wed, Mar 12, 8:44 AM
F15329927: D15590.id37580.diff
Fri, Mar 7, 7:10 AM
Unknown Object (File)
Sat, Mar 1, 6:40 AM
Unknown Object (File)
Thu, Feb 27, 10:42 PM
Unknown Object (File)
Feb 9 2025, 1:11 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8940: Annotate badges with awarder, date
Commits
rP88d15ce79910: Adding awarder info to recipient list on badge view
Summary

Closes T8940, recipient list in badge view should show awarder and date info. Took a first stab at how we want to make the date look, but not sure. Looks odd as it is.

Test Plan

Open badge that has awards. Each recipient in list should have a subheader such as "Awarded by ... on ..."

Diff Detail

Repository
rP Phabricator
Branch
badgeviewawarderinfo
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11448
Build 14273: Run Core Tests
Build 14272: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37580.Apr 3 2016, 2:19 AM
lpriestley retitled this revision from to Adding awarder info to recipient list on badge view.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8940: Annotate badges with awarder, date.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 3 2016, 2:19 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 3 2016, 2:35 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 3 2016, 2:35 AM
Closed by commit rP88d15ce79910: Adding awarder info to recipient list on badge view (authored by lpriestley, committed by lpriestley). · Explain WhyApr 3 2016, 3:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
view/
10 lines

Diff 37580

View Options

src/applications/badges/view/PhabricatorBadgesRecipientsListView.php

Loading...
Phabricator · Built by Phacility