Differential D15589

Fixing the badges query, yet again
ClosedPublic
Actions

Authored by lpriestley on Apr 3 2016, 1:53 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPe66bf175050e: Fixing the badges query, yet again

Summary

Forgot a more efficient way to get badge from award

Test Plan

Badges on user profiles should still show up with awarder handle on the back of the card

Diff Detail

Repository

rP Phabricator

Branch

badgesoptimize

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11446
Build 14270: Run Core Tests
Build 14269: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37577.Apr 3 2016, 1:53 AM

lpriestley retitled this revision from to Fixing the badges query, yet again.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 3 2016, 1:53 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 3 2016, 1:55 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/people/controller/PhabricatorPeopleProfileViewController.php
193–199	You can get rid of this now, since the loop added the badges by PHID key for you.

This revision is now accepted and ready to land.Apr 3 2016, 1:55 AM

redundundun

Closed by commit rPe66bf175050e: Fixing the badges query, yet again (authored by lpriestley, committed by lpriestley). · Explain WhyApr 3 2016, 1:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileViewController.php

14 lines

Diff 37578

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Fixing the badges query, yet againClosedPublicActions