Fixes T10670, for users with exclusively archived badges, user profile should show "no badges" message instead of blank box
Details
Details
Award badge to user with no badges, archive badge, user profile should show "no badges" message under badges.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- peoplearchivedbadges
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11325 Build 14089: Run Core Tests Build 14088: arc lint + arc unit
Event Timeline
src/applications/people/controller/PhabricatorPeopleProfileViewController.php | ||
---|---|---|
192 | For consistency and robustness, consider $badges = array(); instead of $badges = null;, so that $badges always has the same type (an array) -- this mostly just makes it less likely that code later will get tripped up if it does something like You have count($badges) badges. or foreach ($badges as ...), which will work correctly if $badges is array() but not if it is null. |