Differential D15533

Adding basic transaction titles to awarding/revoking badges
ClosedPublic
Actions

Authored by lpriestley on Mar 28 2016, 4:25 PM.

Tags

None

Referenced Files

	F14826513: D15533.diff
	Wed, Jan 29, 1:39 AM

	Unknown Object (File)
	Mon, Jan 27, 9:47 AM

	Unknown Object (File)
	Sat, Jan 25, 5:05 AM

	Unknown Object (File)
	Fri, Jan 24, 12:29 PM

	Unknown Object (File)
	Fri, Jan 24, 12:29 PM

	Unknown Object (File)
	Fri, Jan 24, 12:29 PM

	Unknown Object (File)
	Fri, Jan 24, 12:29 PM

	Unknown Object (File)
	Fri, Jan 24, 12:29 PM

Subscribers

Tokens

"Haypence" token, awarded by chad.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10677: Update Badge transaction titles

Commits

rPe6d2e66ea250: Adding basic transaction titles to awarding/revoking badges

Summary

Ref T10677, awarding/revoking a badge should create timeline entries with titles that are more clear (excludes homepage feed stories)

Test Plan

Award/revoke a badge to single or multiple users. See timeline entries that reflect those actions.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37447.Mar 28 2016, 4:25 PM

lpriestley retitled this revision from to Adding basic transaction titles to awarding/revoking badges.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T10677: Update Badge transaction titles.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 28 2016, 4:25 PM

Herald added a subscriber: Korvin. · View Herald Transcript

lpriestley updated this object.Mar 28 2016, 4:25 PM

lpriestley edited edge metadata.

chad awarded a token.Mar 28 2016, 4:26 PM

epriestley accepted this revision.Mar 28 2016, 4:33 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/badges/storage/PhabricatorBadgesTransaction.php
118	This reads a little awkwardly to me -- maybe "%s awarded this badge to %s recipient(s): %s"?
128	This too -- maybe "%s revoked this badge from %s recipient(s): %s"?
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1532–1544	If you do make wording changes, update these too.

This revision is now accepted and ready to land.Mar 28 2016, 4:33 PM

Updating to epriestley wording

Closed by commit rPe6d2e66ea250: Adding basic transaction titles to awarding/revoking badges (authored by lpriestley, committed by lpriestley). · Explain WhyMar 28 2016, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

storage/

PhabricatorBadgesTransaction.php

40 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

14 lines

Diff 37449

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...