Differential D15533

Adding basic transaction titles to awarding/revoking badges
ClosedPublic
Actions

Authored by lpriestley on Mar 28 2016, 4:25 PM.

Tags

None

Referenced Files

	F13236993: D15533.diff
	Tue, May 21, 11:57 AM

	F13236978: D15533.id37448.diff
	Tue, May 21, 11:54 AM

	F13226791: D15533.id37449.diff
	Sun, May 19, 11:26 PM

	F13217041: D15533.diff
	Sat, May 18, 3:36 AM

	F13187051: D15533.diff
	Sat, May 11, 4:18 AM

	F13175260: D15533.diff
	Wed, May 8, 4:19 AM

	Unknown Object (File)
	Tue, May 7, 7:23 AM

	Unknown Object (File)
	Fri, May 3, 6:06 AM

Subscribers

Tokens

"Haypence" token, awarded by chad.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10677: Update Badge transaction titles

Commits

rPe6d2e66ea250: Adding basic transaction titles to awarding/revoking badges

Summary

Ref T10677, awarding/revoking a badge should create timeline entries with titles that are more clear (excludes homepage feed stories)

Test Plan

Award/revoke a badge to single or multiple users. See timeline entries that reflect those actions.

Diff Detail

Repository

Branch

badgestransactions

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11313
Build 14070: Run Core Tests
Build 14069: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37447.Mar 28 2016, 4:25 PM

lpriestley retitled this revision from to Adding basic transaction titles to awarding/revoking badges.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T10677: Update Badge transaction titles.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 28 2016, 4:25 PM

Herald added a subscriber: Korvin. · View Herald Transcript

lpriestley updated this object.Mar 28 2016, 4:25 PM

lpriestley edited edge metadata.

chad awarded a token.Mar 28 2016, 4:26 PM

epriestley accepted this revision.Mar 28 2016, 4:33 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/badges/storage/PhabricatorBadgesTransaction.php
118	This reads a little awkwardly to me -- maybe "%s awarded this badge to %s recipient(s): %s"?
128	This too -- maybe "%s revoked this badge from %s recipient(s): %s"?
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1532–1544	If you do make wording changes, update these too.

This revision is now accepted and ready to land.Mar 28 2016, 4:33 PM

Updating to epriestley wording

Closed by commit rPe6d2e66ea250: Adding basic transaction titles to awarding/revoking badges (authored by lpriestley, committed by lpriestley). · Explain WhyMar 28 2016, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

storage/

PhabricatorBadgesTransaction.php

40 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

14 lines

Diff 37448

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...