Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually.
Split ContentSource apart so applications can add new content sources.
Differential D15521 Authored by epriestley on Mar 25 2016, 1:51 PM.
Tags None Referenced Files
Subscribers None
Details
Summary Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually. Split ContentSource apart so applications can add new content sources. Test Plan This change has huge surface area, so I'll hold it until post-release. I think it's fairly safe (and if it does break anything, the breaks should be fatals, not anything subtle or difficult to fix), there's just no reason not to hold it for a few hours.
Diff Detail
Event Timelineepriestley updated this object. Herald edited edge metadata. · View Herald TranscriptMar 25 2016, 1:51 PM2016-03-25 13:51:52 (UTC+0) chad edited edge metadata. This revision is now accepted and ready to land.Mar 25 2016, 10:50 PM2016-03-25 22:50:59 (UTC+0) Closed by commit rP601aaa5a86c1: Modularize content sources (authored by epriestley, committed by epriestley). · Explain WhyMar 26 2016, 6:59 PM2016-03-26 18:59:50 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37433 src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.phpLoading... src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.phpLoading... src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.phpLoading... |