Page MenuHomePhabricator

Modularize content sources
ClosedPublic

Authored by epriestley on Mar 25 2016, 1:51 PM.
Tags
None
Referenced Files
F14316749: D15521.diff
Wed, Dec 18, 7:33 AM
Unknown Object (File)
Sun, Dec 1, 2:51 PM
Unknown Object (File)
Tue, Nov 26, 2:43 PM
Unknown Object (File)
Tue, Nov 19, 3:20 PM
Unknown Object (File)
Nov 10 2024, 8:32 AM
Unknown Object (File)
Oct 26 2024, 1:04 PM
Unknown Object (File)
Oct 21 2024, 6:40 PM
Unknown Object (File)
Oct 14 2024, 2:14 AM
Subscribers
None

Details

Summary

Ref T10537. For Nuance, I want to introduce new sources (like "GitHub" or "GitHub via Nuance" or something) but this needs to modularize eventually.

Split ContentSource apart so applications can add new content sources.

Test Plan

This change has huge surface area, so I'll hold it until post-release. I think it's fairly safe (and if it does break anything, the breaks should be fatals, not anything subtle or difficult to fix), there's just no reason not to hold it for a few hours.

  • Viewed new module page.
  • Grepped for all removed functions/constants.
  • Viewed some transactions.
  • Hovered over timestamps to get content source details.
  • Added a comment via Conduit.
  • Added a comment via web.
  • Ran bin/storage upgrade --namespace XXXXX --no-quickstart -f to re-run all historic migrations.
  • Generated some objects with bin/lipsum.
  • Ran a bulk job on some tasks.
  • Ran unit tests.

Screen Shot 2016-03-25 at 6.42.23 AM.png (1×1 px, 249 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize content sources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2016, 10:50 PM
This revision was automatically updated to reflect the committed changes.