Page MenuHomePhabricator
Differential D15510

Pick better GitHub URIs for comment events
ClosedPublic
Actions

Authored by epriestley on Mar 22 2016, 10:21 PM.
Tags
None
Referenced Files
F13149023: D15510.diff
Sat, May 4, 6:04 AM
Unknown Object (File)
Fri, May 3, 7:04 AM
Unknown Object (File)
Thu, Apr 25, 1:25 AM
Unknown Object (File)
Tue, Apr 16, 6:43 PM
Unknown Object (File)
Tue, Apr 9, 10:16 AM
Unknown Object (File)
Sun, Apr 7, 9:44 PM
Unknown Object (File)
Apr 1 2024, 10:39 PM
Unknown Object (File)
Mar 18 2024, 9:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10538: Bridge GitHub to Phabricator
Commits
Restricted Diffusion Commit
rPdac07921f71a: Pick better GitHub URIs for comment events
Summary

Ref T10538. Boundless joy.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Branch
nuance21
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11256
Build 13981: Run Core Tests
Build 13980: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37393.Mar 22 2016, 10:21 PM
epriestley retitled this revision from to Pick better GitHub URIs for comment events..
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10538: Bridge GitHub to Phabricator.
Herald edited edge metadata. · View Herald TranscriptMar 22 2016, 10:21 PM
chad accepted this revision.Mar 22 2016, 10:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 10:21 PM
chad retitled this revision from Pick better GitHub URIs for comment events. to Pick better GitHub URIs for comment events.Mar 22 2016, 10:21 PM
chad edited edge metadata.
epriestley added a comment.Mar 22 2016, 10:21 PM

thx :3

Closed by commit rPdac07921f71a: Pick better GitHub URIs for comment events (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 10:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
nuance/
github/
25 lines
__tests__/
repositoryevents/
2 lines
2 lines

Diff 37393

View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt

Loading...
Phabricator · Built by Phacility