Page MenuHomePhabricator
Differential D15508

Fix tag limit logic in PHUIHandleTagListView
ClosedPublic
Actions

Authored by epriestley on Mar 22 2016, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 5:21 AM
Unknown Object (File)
Wed, Dec 11, 9:51 PM
Unknown Object (File)
Mon, Dec 9, 11:29 AM
Unknown Object (File)
Thu, Nov 28, 4:33 PM
Unknown Object (File)
Wed, Nov 27, 10:12 AM
Unknown Object (File)
Wed, Nov 27, 7:28 AM
Unknown Object (File)
Tue, Nov 26, 6:54 PM
Unknown Object (File)
Mon, Nov 25, 4:05 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10648: Task project list ellipsis displays unecessary
Commits
Restricted Diffusion Commit
rP86720b4595a7: Fix tag limit logic in PHUIHandleTagListView
Summary

Fixes T10648. This was goofed and always did a meaningless no-op slice -- I mucked it up while doing the disabled project stuff elsewhere.

Test Plan
  • Tagged something with 5 projects.
  • Saw the list sliced to 4 (the limit) with "...".

Diff Detail

Repository
rP Phabricator
Branch
taglimit
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11244
Build 13966: Run Core Tests
Build 13965: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37380.Mar 22 2016, 4:21 PM
epriestley retitled this revision from to Fix tag limit logic in PHUIHandleTagListView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10648: Task project list ellipsis displays unecessary.
Herald edited edge metadata. · View Herald TranscriptMar 22 2016, 4:21 PM
chad accepted this revision.Mar 22 2016, 4:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 4:27 PM
epriestley added a comment.Mar 22 2016, 4:27 PM

Maybe it would be clearer to say count > limit instead of limit < count, let me swap that.

epriestley updated this revision to Diff 37381.Mar 22 2016, 4:29 PM
epriestley edited edge metadata.
  • Use slightly more clear expressions.
Closed by commit rP86720b4595a7: Fix tag limit logic in PHUIHandleTagListView (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 4:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phid/
view/
4 lines

Diff 37381

View Options

src/applications/phid/view/PHUIHandleTagListView.php

Loading...
Phabricator · Built by Phacility