Fix tag limit logic in PHUIHandleTagListView
ClosedPublic
Actions

Authored by epriestley on Mar 22 2016, 4:21 PM.

Details

Reviewers

chad

Maniphest Tasks

T10648: Task project list ellipsis displays unecessary

Commits

Restricted Diffusion Commit
rP86720b4595a7: Fix tag limit logic in PHUIHandleTagListView

Summary

Fixes T10648. This was goofed and always did a meaningless no-op slice -- I mucked it up while doing the disabled project stuff elsewhere.

Test Plan

Tagged something with 5 projects.
Saw the list sliced to 4 (the limit) with "...".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37380.Mar 22 2016, 4:21 PM

epriestley retitled this revision from to Fix tag limit logic in PHUIHandleTagListView.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10648: Task project list ellipsis displays unecessary.

Herald edited edge metadata. · View Herald TranscriptMar 22 2016, 4:21 PM

chad accepted this revision.Mar 22 2016, 4:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 22 2016, 4:27 PM

Maybe it would be clearer to say count > limit instead of limit < count, let me swap that.

Use slightly more clear expressions.

Closed by commit rP86720b4595a7: Fix tag limit logic in PHUIHandleTagListView (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 4:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phid/

view/

PHUIHandleTagListView.php

4 lines

Diff 37382

View Options

src/applications/phid/view/PHUIHandleTagListView.php

Fix tag limit logic in PHUIHandleTagListViewClosedPublicActions