Page MenuHomePhabricator

Fix an initialization issue in Herald rules in Chrome
ClosedPublic

Authored by epriestley on Mar 22 2016, 4:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 12:23 AM
Unknown Object (File)
Sat, Feb 1, 1:29 AM
Unknown Object (File)
Sat, Jan 25, 10:57 AM
Unknown Object (File)
Fri, Jan 24, 12:24 PM
Unknown Object (File)
Fri, Jan 24, 12:24 PM
Unknown Object (File)
Fri, Jan 24, 12:24 PM
Unknown Object (File)
Mon, Jan 13, 3:06 AM
Unknown Object (File)
Dec 9 2024, 4:12 PM
Subscribers
None

Details

Summary

Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values.

Currently, the logic just sets everything to null or 'default'. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.)

Instead of relying on the browser to pick the right value, set the correct value explicitly.

Test Plan
  • Created a new rule in Chrome, Safari.
  • Added fields and conditions in Chrome, Safari.
  • Edited existing rules in Chrome, Safari.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11241
Build 13961: Run Core Tests
Build 13960: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an initialization issue in Herald rules in Chrome.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.