Differential D15497

When marking up Phurl URLs for mail, use absolute URLs
ClosedPublic
Actions

Authored by epriestley on Mar 18 2016, 10:59 PM.

Details

Reviewers

chad

Maniphest Tasks

T10625: Links like "((prototype))" are not expanded properly in email

Commits

Restricted Diffusion Commit
rP981f3a9068bb: When marking up Phurl URLs for mail, use absolute URLs

Summary

Fixes T10625.

Test Plan

Faked this locallly and it looked OK, I'll check the mail in production. :3333

Diff Detail

Repository

rP Phabricator

Branch

phurl1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11216
Build 13923: Run Core Tests
Build 13922: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37356.Mar 18 2016, 10:59 PM

epriestley retitled this revision from to When marking up Phurl URLs for mail, use absolute URLs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10625: Links like "((prototype))" are not expanded properly in email.

Herald edited edge metadata. · View Herald TranscriptMar 18 2016, 10:59 PM

chad accepted this revision.Mar 18 2016, 11:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 18 2016, 11:00 PM

Closed by commit rP981f3a9068bb: When marking up Phurl URLs for mail, use absolute URLs (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 11:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

remarkup/

PhabricatorPhurlLinkRemarkupRule.php

55 lines

Diff 37356

View Options

src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php

When marking up Phurl URLs for mail, use absolute URLsClosedPublicActions