Page MenuHomePhabricator
Differential D15496

Couple of Diffusion tweaks
ClosedPublic
Actions

Authored by chad on Mar 18 2016, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 8:53 AM
Unknown Object (File)
Feb 9 2025, 1:03 AM
Unknown Object (File)
Feb 9 2025, 1:03 AM
Unknown Object (File)
Feb 9 2025, 1:03 AM
Unknown Object (File)
Feb 9 2025, 1:03 AM
Unknown Object (File)
Feb 8 2025, 5:17 PM
Unknown Object (File)
Jan 24 2025, 12:22 PM
Unknown Object (File)
Jan 24 2025, 12:22 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10615: Very large commit spacing seems off
Commits
Restricted Diffusion Commit
rP01885cad1cbd: Couple of Diffusion tweaks
Summary
  • Fix spacing on InfoView inside collasped boxes
  • Fix spacing on stacked PropertyLists in TwoColumn
  • Fix spacing on Readmes on Tablets
  • Fix unset variable on importing commits
Test Plan

Review each of the above cases.

Diff Detail

Repository
rP Phabricator
Branch
big-azz-commit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11214
Build 13920: Run Core Tests
Build 13919: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37354.Mar 18 2016, 7:04 PM
chad retitled this revision from to Couple of Diffusion tweaks.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 18 2016, 7:04 PM
epriestley accepted this revision.Mar 18 2016, 7:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 7:05 PM
Closed by commit rP01885cad1cbd: Couple of Diffusion tweaks (authored by chad, committed by chad). · Explain WhyMar 18 2016, 7:06 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T10615: Very large commit spacing seems off.Mar 18 2016, 7:06 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
diffusion/
controller/
2 lines
webroot/
rsrc/
css/
application/
diffusion/
1 line
phui/
9 lines

Diff 37354

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-readme.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility