Page MenuHomePhabricator
Differential D15496

Couple of Diffusion tweaks
ClosedPublic
Actions

Authored by chad on Mar 18 2016, 7:04 PM.
Tags
None
Referenced Files
F18834854: D15496.id.diff
Sun, Oct 26, 11:22 AM
F18832810: D15496.diff
Sat, Oct 25, 11:13 PM
F18780279: D15496.id37354.diff
Sun, Oct 12, 5:16 AM
F18671960: D15496.id37354.diff
Sep 25 2025, 6:04 AM
F18241670: D15496.diff
Aug 21 2025, 3:10 AM
F18169895: D15496.id37355.diff
Aug 15 2025, 5:34 PM
F18109523: D15496.id37354.diff
Aug 11 2025, 2:16 PM
F18109081: D15496.id.diff
Aug 11 2025, 11:40 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10615: Very large commit spacing seems off
Commits
Restricted Diffusion Commit
rP01885cad1cbd: Couple of Diffusion tweaks
Summary
  • Fix spacing on InfoView inside collasped boxes
  • Fix spacing on stacked PropertyLists in TwoColumn
  • Fix spacing on Readmes on Tablets
  • Fix unset variable on importing commits
Test Plan

Review each of the above cases.

Diff Detail

Repository
rP Phabricator
Branch
big-azz-commit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11214
Build 13920: Run Core Tests
Build 13919: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37354.Mar 18 2016, 7:04 PM
chad retitled this revision from to Couple of Diffusion tweaks.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 18 2016, 7:04 PM
epriestley accepted this revision.Mar 18 2016, 7:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 7:05 PM
Closed by commit rP01885cad1cbd: Couple of Diffusion tweaks (authored by chad, committed by chad). · Explain WhyMar 18 2016, 7:06 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T10615: Very large commit spacing seems off.Mar 18 2016, 7:06 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
diffusion/
controller/
2 lines
webroot/
rsrc/
css/
application/
diffusion/
1 line
phui/
9 lines

Diff 37354

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-readme.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility