Page MenuHomePhabricator
Differential D15495

Make dates/times more concise in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 18 2016, 4:00 PM.
Tags
None
Referenced Files
F13282617: D15495.diff
Sun, Jun 2, 12:17 PM
F13272672: D15495.id37347.diff
Thu, May 30, 5:09 PM
F13272671: D15495.id37348.diff
Thu, May 30, 5:08 PM
F13269065: D15495.diff
Wed, May 29, 5:45 AM
F13254558: D15495.diff
Sat, May 25, 3:30 AM
F13233887: D15495.diff
Tue, May 21, 2:38 AM
F13224443: D15495.id.diff
Sun, May 19, 8:35 AM
F13215703: D15495.id37347.diff
Fri, May 17, 7:16 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPf07d0ae7c3ae: Make dates/times more concise in Diffusion
Summary

I think I like this better -- but maybe right-aligned?

Test Plan

Screen Shot 2016-03-18 at 8.58.48 AM.png (1×2 px, 398 KB)

Screen Shot 2016-03-18 at 8.59.03 AM.png (1×2 px, 324 KB)

Diff Detail

Repository
rP Phabricator
Branch
shorttime
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11207
Build 13911: Run Core Tests
Build 13910: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37347.Mar 18 2016, 4:00 PM
epriestley retitled this revision from to Make dates/times more concise in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptMar 18 2016, 4:00 PM
chad accepted this revision.Mar 18 2016, 4:02 PM
chad edited edge metadata.

right aligned would be great

This revision is now accepted and ready to land.Mar 18 2016, 4:02 PM
epriestley updated this revision to Diff 37348.Mar 18 2016, 4:10 PM
epriestley edited edge metadata.
  • Right-align everything.

I could also maybe using a grey text for this or something? I think it's an improvement but it still doesn't look quite right to me. Maybe I just need to get used to it, though.

Closed by commit rPf07d0ae7c3ae: Make dates/times more concise in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
2 lines
view/
2 lines
2 lines
2 lines
3 lines
people/
storage/
32 lines

Diff 37347

View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility