Page MenuHomePhabricator
Differential D15479

Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 1:26 PM.
Tags
None
Referenced Files
F13161751: D15479.diff
Mon, May 6, 9:37 AM
Unknown Object (File)
Wed, May 1, 11:09 PM
Unknown Object (File)
Sun, Apr 28, 4:01 PM
Unknown Object (File)
Sat, Apr 27, 7:53 PM
Unknown Object (File)
Wed, Apr 24, 10:37 AM
Unknown Object (File)
Wed, Apr 24, 10:37 AM
Unknown Object (File)
Wed, Apr 24, 10:37 AM
Unknown Object (File)
Tue, Apr 16, 7:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10603: Make AuthTemporaryTokens suitable for use as LFS tokens
Commits
Restricted Diffusion Commit
rP33a95d44bdc7: Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens
Summary

Ref T10603. We have a couple of sort of ad-hoc tokens, so start formalizing them. First up is MFA tokens.

Also adds a new config module panel for these.

Test Plan
  • Added MFA.
  • Added MFA, intentionally fumbled the input, completed the workflow.
  • Removed MFA.
  • Viewed tokens, saw MFA sync tokens.
  • Viewed new module config panel.

Screen Shot 2016-03-16 at 6.24.11 AM.png (789×1 px, 157 KB)

Diff Detail

Repository
rP Phabricator
Branch
lfs4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11166
Build 13848: Run Core Tests
Build 13847: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37305.Mar 16 2016, 1:26 PM
epriestley retitled this revision from to Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.
Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 1:26 PM
chad accepted this revision.Mar 16 2016, 3:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 3:36 PM
Closed by commit rP33a95d44bdc7: Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37305

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/factor/PhabricatorAuthTOTPKeyTemporaryTokenType.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/tokentype/PhabricatorAuthOneTimeLoginTemporaryTokenType.php

Loading...
View Options

src/applications/auth/tokentype/PhabricatorAuthPasswordResetTemporaryTokenType.php

Loading...
View Options

src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenType.php

Loading...
View Options

src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenTypeModule.php

Loading...
Phabricator · Built by Phacility