Differential D15470

Update Diff view page to new layout
ClosedPublic
Actions

Authored by chad on Mar 13 2016, 10:53 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T10577: Table of contents on unattached diff view lost a margin

Commits

Restricted Diffusion Commit
rPd76175285e96: Update Diff view page to new layout

Summary

Converts Diff View, single column though.

Test Plan

Upload a new diff, review page.

Diff Detail

Repository

rP Phabricator

Branch

diff-two (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11152
Build 13826: Run Core Tests
Build 13825: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37288.Mar 13 2016, 10:53 PM

chad retitled this revision from to Update Diff view page to new layout.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 13 2016, 10:53 PM

epriestley accepted this revision.Mar 13 2016, 10:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 13 2016, 10:59 PM

epriestley added inline comments.Mar 13 2016, 11:00 PM

src/applications/differential/controller/DifferentialDiffViewController.php
146–156	Oh, get rid of this now?

derp

Closed by commit rPd76175285e96: Update Diff view page to new layout (authored by chad, committed by chad). · Explain WhyMar 13 2016, 11:04 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T10577: Table of contents on unattached diff view lost a margin.Mar 13 2016, 11:28 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialDiffViewController.php

27 lines

Diff 37289

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Update Diff view page to new layoutClosedPublicActions